Skip to content

Use OpenSSL NCONF APIs #7337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 8, 2021
Merged

Use OpenSSL NCONF APIs #7337

merged 1 commit into from
Aug 8, 2021

Conversation

nikic
Copy link
Member

@nikic nikic commented Aug 3, 2021

Switch from the CONF to the higher level / recommended NCONF APIs. This fixes a number of segfaults with OpenSSL 3 due to a semantic change in X509V3_EXT_add_conf (which now frees the passed config).

@nikic nikic requested a review from bukka August 3, 2021 15:45
Copy link
Member

@bukka bukka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me.

@bukka
Copy link
Member

bukka commented Aug 8, 2021

Merging this as well to have it all in master.

@bukka bukka merged commit 94bc5fc into php:master Aug 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants